Switch to isolated declarations for faster builds#841
Open
Switch to isolated declarations for faster builds#841
Conversation
a1d7212 to
1b22a1c
Compare
Member
|
I merged the explicit module boundary type changes and typescript update separately, since those are good to have regardless of TS settings. But I'm confused about some aspects of the remaining changes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small repo, so it isn't strictly necessary. However, isolated declarations is giving us a 14.59s -> 5.43s improvement in typechecking. This change includes the following: